This was my first time implementing a mobile navigation without watching a tutorial. I also implemented the image slideshow on the sign up page using javascript.
- 2
Join Our Discord Channel
Chat and discuss solutions with a growing community of developers.
Hello! You've done great, I have some suggestions that you could work on So I noticed you made use of these properties on each section, I'm guessing you're making use of the padding for mobile devices view, which is totally cool but here another approach. // yours header, main, footer { margin: 0 auto; max-width: 1000px; padding: 0 30px; } // another approach .container { width: 90%; max-width: 1000px; margin: 0 auto; } the width of 90% does give mobile devices some space, which fixes the padding. But your implementation is all good though. Also I notice this: <div class="header-wrap"> </div>
Also I noticed this: <div class="header-wrap"> <header> .... </header> </div> Semantically there's no need for the div element, you could use the header, main, footer elements directly. Lastly, the solution lacks white space, majority of the elements are too close to each other. That's all, I hope it was helpful even though you didn't ask :)